Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update sdk links #2188

Closed
wants to merge 2 commits into from
Closed

docs: update sdk links #2188

wants to merge 2 commits into from

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Feb 3, 2022

update the rest of sdk links missed in #2187.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #2188 (66756cb) into master (9ce2b9e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
+ Coverage   75.31%   75.33%   +0.02%     
==========================================
  Files         294      294              
  Lines       15651    15651              
==========================================
+ Hits        11787    11791       +4     
+ Misses       3032     3029       -3     
+ Partials      832      831       -1
Impacted Files Coverage Δ
session/test/persistence.go 100.00% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce2b9e...66756cb. Read the comment docs.

@aeneasr
Copy link
Member

aeneasr commented Feb 3, 2022

I noticed that the SDKs do not yet work with open source deployments, so we need to keep this on the back burner for now

@aeneasr aeneasr marked this pull request as draft February 3, 2022 16:28
@aeneasr
Copy link
Member

aeneasr commented Feb 16, 2022

I am closing this for now, it needs more work on maintainer side first

@aeneasr aeneasr closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinckr @aeneasr